Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix s3fs/boto requirements and unpin numpy #1143

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Fix s3fs/boto requirements and unpin numpy #1143

merged 3 commits into from
Jan 16, 2025
+6 −7

Conversation

timj
Copy link
Member

@timj timj commented Jan 16, 2025

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

timj added 2 commits January 16, 2025 14:59
@timj
Install s3fs as a test requirement
ed6a6e3 
This allows the requirements.txt to be solved in a self
consistent manner. Otherwise installing s3fs later can
lead to botcore and boto3 becoming incompatible with
each other.
@timj
Allow numpy 2 in requirements
3320301
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.49%. Comparing base (36545c9) to head (ac1af00).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1143   +/-   ##
=======================================
  Coverage   89.49%   89.49%           
=======================================
  Files         366      366           
  Lines       49020    49020           
  Branches     5941     5941           
=======================================
  Hits        43872    43872           
  Misses       3733     3733           
  Partials     1415     1415

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj
Cast astropy time MJD to float from np.float64
ac1af00 
In numpy 2 sqlalchemy refuses to handle np.float64 and so the times
must be converted to Python float.
@timj timj requested a review from dhirving January 16, 2025 22:39
@timj
Copy link
Member Author

timj commented Jan 16, 2025

@dhirving can you take a look at this please? It will let us quickly fix the pypi release.

@timj timj merged commit e3be3c4 into main Jan 16, 2025
19 checks passed
@timj timj deleted the u/timj/fix-boto-numpy-pins branch January 16, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhirving dhirving dhirving approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timj @dhirving