DM-48288: Do not cache collection summaries by default in queries #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1138 +/- ##
=======================================
Coverage 89.50% 89.50%
=======================================
Files 366 366
Lines 49007 49015 +8
Branches 5941 5941
=======================================
+ Hits 43863 43872 +9
+ Misses 3729 3728 -1
Partials 1415 1415 ☔ View full report in Codecov by Sentry. |
dhirving
force-pushed
the
tickets/DM-48288
branch
from
bc957cd to
bc14e25
Compare
dhirving
force-pushed
the
tickets/DM-48288
branch
from
bc14e25 to
f6e4480
Compare
dhirving
changed the title
dhirving
force-pushed
the
tickets/DM-48288
branch
from
f6e4480 to
25f4e5f
Compare
andy-slac
approved these changes
Jan 13, 2025
| self._depth -= 1 | ||
| else: | ||
| raise AssertionError("Bad caching context management detected.") | ||
| return self._collection_records.enable() |
There was a problem hiding this comment.
Should it be _collection_summaries?
There was a problem hiding this comment.
.... yes it should.
We now enable the collection summary cache separately from the collection record cache. In the Butler.query() context, only the collection record cache is enabled by default. More often than not, the query context manager is used to execute one query and then exited. The collection summary cache was often a pessimization in this case -- fetching tens of thousands of rows when only a few were needed.
Enable the caching context a few places where we do repeated dataset queries over the same collections. This allows us to avoid repeated collection summary lookups.
dhirving
force-pushed
the
tickets/DM-48288
branch
from
25f4e5f to
409b870
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now enable the collection summary cache separately from the collection record cache. In the Butler.query() context, only the collection record cache is now enabled by default. When Butler.registry.caching_context() is called, both caches are enabled (as before.)
More often than not, the query context manager is used to execute one query and then exited. The collection summary cache was often a pessimization in this case -- fetching tens of thousands of rows when only a few were needed.
Also added explicit caching context calls to a few places in the Butler internals where we are doing repeated dataset queries that will benefit from the cache.
Checklist
doc/changesconfigs/old_dimensions