Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46914: Add ability for ObsCore record facility name to vary by instrument #1122

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

timj
Copy link
Member

@timj timj commented Nov 22, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.44%. Comparing base (1efb2aa) to head (55e1141).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1122   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files         366      366           
  Lines       48610    48614    +4     
  Branches     5890     5890           
=======================================
+ Hits        43481    43485    +4     
  Misses       3717     3717           
  Partials     1412     1412           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

python/lsst/daf/butler/registry/obscore/_records.py Outdated Show resolved Hide resolved
@timj timj force-pushed the tickets/DM-46914 branch from ead285e to a4f6736 Compare December 2, 2024 21:24
@timj timj force-pushed the tickets/DM-46914 branch from a4f6736 to 55e1141 Compare December 3, 2024 23:10
@timj timj merged commit f8303a5 into main Dec 4, 2024
19 checks passed
@timj timj deleted the tickets/DM-46914 branch December 4, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants