first crack at RFC from Oct 23 meeting #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
See description and comments in DM-47132 |
Vebop
reviewed
Oct 25, 2024
notebooks_tsqr/NightLog.ipynb
Outdated
| @@ -27,7 +27,7 @@ | |||
| "day_obs = \"2024-09-25\" # TODO Change to 'YESTERDAY' to test with default before push\n", | |||
There was a problem hiding this comment.
Line #2. if allsrc.exp_src.exposures["LATISS"]:
This is not a TODO to fix on this PR but me noticing where we need to clarify:
I am reading as this to only apply to latiss, but I think these portions where in the storyboard we have 'LATISS' as 'This selected instrument, latiss being one of them'
Would you agree that this section would be valid for any of the instruments?
I think we just need to implement that larger selectable instrument part still.
Reply via ReviewNB
Vebop
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to cover as many changes from Oct 23 meeting as I could within 1-2 days. Some needed changes remain. This was based on meeting notes, not storyboard.