Tickets/DM-47619 Update implementation of the ignore feature in scripts. #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Minor fix in `BaseTakePTCFlats.get_schema` - Added a `test_configure_ignore` for script `take_ptc_flats_comcam.py`
Also: - Remove default value for the `ignore` attribute in `get_schema()` - Added a `test_configure_ignore` to the script tests
…sGenCam Also: - Remove default value for the `ignore` attribute in `get_schema()` - Update `move_dome()` - Added a `test_configure_ignore` to the script tests
Also: - Remove default value for the `ignore` attribute in `get_schema()` - Added a `test_configure_ignore` to the script tests
Also: - Move the implementation of the ignore feature of MTCS components from the base-class to `TakeTwilightFlatsComCam` and `TakeTwilightFlatsLSSTCam`. - Added a `test_configure_ignore` to the script tests
tribeiro
requested changes
Jan 6, 2025
| if hasattr(config, "ignore"): | ||
| # Ignoring only specific MTCS components | ||
| allowed_ignore = ["mtdome", "mtdometrajectory"] | ||
| for comp in map(RemoteGroup._remote_name_to_attr_format, config.ignore): |
There was a problem hiding this comment.
This is using a "private" method from RemoteGroup. Not sure I understand what is going on here. Can you please clarify?
| if hasattr(config, "ignore"): | ||
| # Ignoring only specific MTCS components | ||
| allowed_ignore = ["mtdome", "mtdometrajectory"] | ||
| for comp in map(RemoteGroup._remote_name_to_attr_format, config.ignore): |
There was a problem hiding this comment.
Again, this is using a "private" method from RemoteGroup. Not sure I understand what is going on here. Can you please, clarify?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update scripts to use the
disable_checks_for_componentsmethod of theRemoteGroupclass.