Add values.yaml for DREAM & ATBuilding on summit #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribeiro
reviewed
Nov 12, 2024
apps/auxtel/values-summit.yaml
Outdated
| @@ -10,3 +10,6 @@ cscs: | |||
| - atspectrograph | |||
| - atheaderservice | |||
| - pmd1 | |||
| spec: | |||
| source: | |||
| targetRevision: tickets/DM-47527 | |||
There was a problem hiding this comment.
do you really want to commit with the target being a ticket branch? I think probably not. Also, I think this is something you can edit easily on argo-cd
apps/eas/values-summit.yaml
Outdated
| @@ -41,3 +41,6 @@ renameMap: | |||
| ess204: auxtel-ess204 | |||
| ess301: calibhill-ess301 | |||
| ess302: earthquake-ess302 | |||
| spec: | |||
| source: | |||
| targetRevision: tickets/DM-47527 | |||
tribeiro
previously approved these changes
Nov 13, 2024
bbrondel
force-pushed
the
tickets/DM-47527
branch
2 times, most recently
from
0046b3c to
9536f4e
Compare
tribeiro
approved these changes
Nov 14, 2024
|
PR is missing the addition of those CSCs to both the kafka-producers and the love-producer applications for the summit configuration. |
Thanks for checking. Now fixed. |
bbrondel
force-pushed
the
tickets/DM-47527
branch
from
87cd443 to
d67c739
Compare
bbrondel
force-pushed
the
tickets/DM-47527
branch
from
d67c739 to
68c2192
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.