U/danielsf/when obs lsst sim breaks #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which directly returns an astropy.coordinates.EarthLocation
(but does not pass)
since there is no phenomenological modeling of the optical distortions going on in sims_coordUtils at this point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jchiang87 @cwwalter @jdswinbank
This pull request should be merged when obs_lsstSim (or the lack thereof) causes lsst_sims to break.
Do not merge it beforehand, as it will delete (as opposed to replacing) functionality that currently depends on obs_lsstSim.
Jim, Chris: I cannot promise that the orientation of pixel x,y coordinates in sims_GalSimInterface will be correct after this gets merged. I think the obs_lsst PhosimMapper() actually respects the camera team coordinate system, the same way PhoSim does. All this branch does is make sure that tests pass and the code builds. Once obs_lsstSim is gone, ImSim should stop using the camera model in sims_GalSimInterface.