Skip to content
This repository has been archived by the owner on Sep 10, 2023. It is now read-only.

Permit both theme and custom classes #756

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mhuggins
Copy link

What's this PR do?

Permits both themes and custom classes. Prior to this pull request, it was not possible to have a theme take effect if you were also trying to pass in any custom classes, e.g.:

$('.token-autocomplete').tokenInput({
  theme: 'bootstrap',
  classes: {
    tokenList: 'token-input-list-bootstrap form-control'
  }
});

How should this be manually tested?

Try all four possibilities to ensure they work as expected.

  1. No theme or classes option passed in.
  2. Just a theme option passed in.
  3. Just a classes option passed in.
  4. Both a theme and classes option passed in.

Any background context you want to provide?

I'm trying to use a theme, but I'd also like to attach an unrelated bootstrap class to the rendered token input.

Screenshots

jquery-tokeninput

What gif best describes this PR or how it makes you feel?

high five!

@mhuggins
Copy link
Author

cc @loopj @hugohenrique

@hugohenrique
Copy link
Collaborator

👍

@loopj loopj force-pushed the master branch 2 times, most recently from fd2316b to 8a8390e Compare August 3, 2023 06:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants