spike: deprecated settings all working #43
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference implementation of things I have talked about in #42, with all existing specs passing.
Notably:
After upgrading this mixin dependency, without any code changes to the plugins that include this mixin:
This is only a spike, and it largely uses the config code as written in #42 but makes it available to plugins in a manner similar to the one described in #42 (review). It does not port the tests from #42, because I wanted to show all specs passing without modification.
Implementation
moduleDeprecatedSslConfigSupport
holds all of the deprecated SSL logicAdapter
dynamic module can be included into a plugin class with or without the Deprecated SSL settings and exposed throughHttpClient#[with_deprecated:]
HttpClient::included
now auto-mixes inAdapter.new(with_deprecated: true)
so that no changes are required in codebases that use this plugin