# 110 Globs that Return Subdirectories Error out #111
Conversation
|
@guyboertje fyi :) |
|
@guyboertje moved to |
|
Nice. LGTM |
|
@original-brownbear remember to bump version, changelog and publish :) |
|
@original-brownbear since you are in this area, this is another candidate for a java rewrite (should continue using Joni to keep backward compatibility with regexes). Something on your list if you are looking for more things :) It would be interesting to see what the benchmark results are for the 2 implementations. /cc @jsvd |
|
@suyograo bump version in this PR or are we always doing a separate one for that? |
|
@suyograo Also, I'll add a separate issue for a Java redo then? |
lib/logstash/filters/grok.rb
Outdated
| # A hash of pattern-name and pattern tuples defining custom patterns to be used by | ||
| # the current filter. Patterns matching existing names will override the pre-existing | ||
| # definition. Think of this as inline patterns available just for this definition of | ||
| # A hash of pattern-name and pattern tuples defining custom patterns to be used by |
There was a problem hiding this comment.
Please disable your editor's "strip trailing whitespace" feature.
lib/logstash/filters/grok.rb
Outdated
| @@ -390,7 +390,7 @@ def patterns_files_from_paths(paths, glob) | |||
|
|
|||
| Dir.glob(path).each do |file| | |||
| @logger.trace("Grok loading patterns from file", :path => file) | |||
| patternfiles << file | |||
| patternfiles << file unless File.directory?(file) | |||
There was a problem hiding this comment.
Let's log when we are skipping things. Perhaps at debug level, logger.debug("Skipping path because it is a directory", :path => file)
|
@jordansissel all fixed I think :) |
|
@original-brownbear you can bump version and changelog in the same PR. |
|
@suyograo bumped version and added changelog entry :) |
|
issue about Java version: #112 |
closes #110
.idea+ autocleanup redundant qualifier on Java import)