Deleted MPI barriers in computeQdot #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jerryntk, take a look, but it would seem it's not creating any problem. Check also that I commented the correct line. |
Decrease number of mpi partitions so it is under the number of mesh elements in the case
Decrease number of MPI threads for UniformFlow and Convergence. These meshes are very small.
|
@AbbBallout , I am getting errors in the new multiphase Vreman test case. May be you were too optimistic with the threshold for detecting an error? Please double check. |
|
Only the gfortran release didn't pass. |
|
@AbbBallout, yeah, I think you are probably right. Can you take a look? Not urgent, so just right in your todo list and take a look when you have some extra time. Thanks! |
|
@loganoz Yeah sure will |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted MPI barriers in computeQdot and computeQdotHO to enhance MPI performance. It might break some implementations without MPI test in CI.