-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOSA] Update tosa.cast check according to TOSA v1.0 spec #3948
base: main
Are you sure you want to change the base?
Conversation
I'm quoting my comment regarding unifying
|
* Update checkValidityOfCast function for tosa.cast according to the latest TOSA v1.0 spec: https://www.mlplatform.org/tosa/tosa_spec.html#_cast * Clean up some dead code in TorchToTosa Signed-off-by: Justin Ngo <[email protected]> Change-Id: I41209c698a694bca57ebf49ed3608cf89a0d8ba8
680d971
to
e32a5b1
Compare
"FullModuleFalsePinMemory_basic", | ||
"FullModuleInt2D_basic", | ||
"MaskedFillScalarFloatValueModule_basic", | ||
"MaskedFillScalarFloatValueStaticModule_basic", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarification: all these tests are now passing because checkValidityOfCast
is not enforced?
Change-Id: I41209c698a694bca57ebf49ed3608cf89a0d8ba8