[CIR][Test][NFC] Organize CIR CodeGen AArch64 neon tests #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghehg
changed the title
bcardosolopes
requested changes
Oct 1, 2024
There was a problem hiding this comment.
How about clang/test/CIR/CodeGen/aarch64-neon-intrinsics.c? Also, clang/test/CIR/CodeGen/aarch64-neon-intrinsics.c has several commented tests, which the intent was to be uncovered as support comes, since you added several other files, make sure you delete the duplicates from those commented out tests.
| // NYI: ret <4 x i16> [[VQADD_V2_I]] | ||
| // int16x4_t test_vqadd_s16(int16x4_t a, int16x4_t b) { | ||
| // return vqadd_s16(a, b); | ||
| // } |
There was a problem hiding this comment.
Thanks for cleaning up this file, one remaining change: this should also go to the subdir AArch64, perhaps call it neon.c.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
as title. --------- Co-authored-by: Guojin He <[email protected]>
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
as title. --------- Co-authored-by: Guojin He <[email protected]>
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
as title. --------- Co-authored-by: Guojin He <[email protected]>
ghehg
added a commit
to ghehg/clangir-llvm-ghehg
that referenced
this pull request
Oct 10, 2024
as title. --------- Co-authored-by: Guojin He <[email protected]>
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
as title. --------- Co-authored-by: Guojin He <[email protected]>
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
as title. --------- Co-authored-by: Guojin He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title.