Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CodeGen][NFC] Break the missing feature flag for OpenCL into smaller pieces #902

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[CIR][CodeGen][NFC] Break the missing feature flag for OpenCL into smaller pieces #902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/include/clang/CIR/MissingFeatures.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ struct MissingFeatures {
static bool CGFPOptionsRAII() { return false; }
static bool getFPFeaturesInEffect() { return false; }
static bool cxxABI() { return false; }
static bool openCL() { return false; }
static bool openCLCXX() { return false; }
static bool openCLBuiltinTypes() { return false; }
static bool CUDA() { return false; }
static bool openMP() { return false; }
Expand Down
2 changes: 1 addition & 1 deletion clang/lib/CIR/CodeGen/CIRGenCXX.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ static void buildDeclDestroy(CIRGenFunction &CGF, const VarDecl *D) {
if (Record && (CanRegisterDestructor || UsingExternalHelper)) {
assert(!D->getTLSKind() && "TLS NYI");
assert(!Record->hasTrivialDestructor());
assert(!MissingFeatures::openCL());
assert(!MissingFeatures::openCLCXX());
CXXDestructorDecl *Dtor = Record->getDestructor();
// In LLVM OG codegen this is done in registerGlobalDtor, but CIRGen
// relies on LoweringPrepare for further decoupling, so build the
Expand Down
1 change: 0 additions & 1 deletion clang/lib/CIR/CodeGen/CIRGenDecl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ CIRGenFunction::AutoVarEmission
CIRGenFunction::buildAutoVarAlloca(const VarDecl &D,
mlir::OpBuilder::InsertPoint ip) {
QualType Ty = D.getType();
assert(!MissingFeatures::openCL());
assert(
Ty.getAddressSpace() == LangAS::Default ||
(Ty.getAddressSpace() == LangAS::opencl_private && getLangOpts().OpenCL));
Expand Down