Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CIRGen] Support pure and deleted virtual functions #823

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

smeenai
Copy link
Collaborator

@smeenai smeenai commented Sep 5, 2024

This is a straightforward adaption of existing CodeGen logic. While I'm
here, move block comments inside their blocks, so that they look nicer.

This is a straightforward adaption of existing CodeGen logic. While I'm
here, move block comments inside their blocks, so that they look nicer.
Copy link
Member

@Lancern Lancern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smeenai smeenai merged commit d167034 into llvm:main Sep 5, 2024
7 checks passed
@smeenai smeenai deleted the pure-virtual branch September 5, 2024 16:56
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
This is a straightforward adaption of existing CodeGen logic. While I'm
here, move block comments inside their blocks, so that they look nicer.
smeenai added a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
This is a straightforward adaption of existing CodeGen logic. While I'm
here, move block comments inside their blocks, so that they look nicer.
smeenai added a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
This is a straightforward adaption of existing CodeGen logic. While I'm
here, move block comments inside their blocks, so that they look nicer.
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
This is a straightforward adaption of existing CodeGen logic. While I'm
here, move block comments inside their blocks, so that they look nicer.
lanza pushed a commit that referenced this pull request Nov 5, 2024
This is a straightforward adaption of existing CodeGen logic. While I'm
here, move block comments inside their blocks, so that they look nicer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants