Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CIRGen] Add initial CIRGen support for local temporary materialization #820

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Lancern
Copy link
Member

@Lancern Lancern commented Sep 4, 2024

This PR adds initial support for temporary materialization of local temporaries with trivial cleanups.

Materialization of global temporaries and local temporaries with non-trivial cleanups is far more trickier that I initially thought and I decide to submit this easy part first.

…ization

This patch adds CIRGen for temporary materialization of local temporaries with
trivial cleanups.
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks

@bcardosolopes bcardosolopes merged commit 97357e1 into llvm:main Sep 9, 2024
7 checks passed
@Lancern Lancern deleted the local-temp-materialize branch September 10, 2024 01:49
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
…ization (llvm#820)

This PR adds initial support for temporary materialization of local
temporaries with trivial cleanups.

Materialization of global temporaries and local temporaries with
non-trivial cleanups is far more trickier that I initially thought and I
decide to submit this easy part first.
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
…ization (llvm#820)

This PR adds initial support for temporary materialization of local
temporaries with trivial cleanups.

Materialization of global temporaries and local temporaries with
non-trivial cleanups is far more trickier that I initially thought and I
decide to submit this easy part first.
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
…ization (llvm#820)

This PR adds initial support for temporary materialization of local
temporaries with trivial cleanups.

Materialization of global temporaries and local temporaries with
non-trivial cleanups is far more trickier that I initially thought and I
decide to submit this easy part first.
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
…ization (llvm#820)

This PR adds initial support for temporary materialization of local
temporaries with trivial cleanups.

Materialization of global temporaries and local temporaries with
non-trivial cleanups is far more trickier that I initially thought and I
decide to submit this easy part first.
lanza pushed a commit that referenced this pull request Nov 5, 2024
…ization (#820)

This PR adds initial support for temporary materialization of local
temporaries with trivial cleanups.

Materialization of global temporaries and local temporaries with
non-trivial cleanups is far more trickier that I initially thought and I
decide to submit this easy part first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants