[CIR][ABI] Add X86_64 and AArch64 bool CC lowering #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements calling convention lowering of bool arguments and return value calling conventions for X86_64 and AArch64. For x86_64, this is a bit of an odd case. In the orignal codegen bools are represented as i8 everywhere, except for function arguments/return values. In CIR, we don't allow i1 types, so bools are still represented as `cir.bool` when in functions. However, when lowering to LLVM Dialect, we need to ensure bools will be converted to i1 when in function's argument/return values.
bcardosolopes
approved these changes
Jul 29, 2024
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
Implements calling convention lowering of bool arguments and return value calling conventions for X86_64 and AArch64. For x86_64, this is a bit of an odd case. In the orignal codegen bools are represented as i8 everywhere, except for function arguments/return values. In CIR, we don't allow i1 types, so bools are still represented as `cir.bool` when in functions. However, when lowering to LLVM Dialect, we need to ensure bools will be converted to i1 when in function's argument/return values.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
Implements calling convention lowering of bool arguments and return value calling conventions for X86_64 and AArch64. For x86_64, this is a bit of an odd case. In the orignal codegen bools are represented as i8 everywhere, except for function arguments/return values. In CIR, we don't allow i1 types, so bools are still represented as `cir.bool` when in functions. However, when lowering to LLVM Dialect, we need to ensure bools will be converted to i1 when in function's argument/return values.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
Implements calling convention lowering of bool arguments and return value calling conventions for X86_64 and AArch64. For x86_64, this is a bit of an odd case. In the orignal codegen bools are represented as i8 everywhere, except for function arguments/return values. In CIR, we don't allow i1 types, so bools are still represented as `cir.bool` when in functions. However, when lowering to LLVM Dialect, we need to ensure bools will be converted to i1 when in function's argument/return values.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
Implements calling convention lowering of bool arguments and return value calling conventions for X86_64 and AArch64. For x86_64, this is a bit of an odd case. In the orignal codegen bools are represented as i8 everywhere, except for function arguments/return values. In CIR, we don't allow i1 types, so bools are still represented as `cir.bool` when in functions. However, when lowering to LLVM Dialect, we need to ensure bools will be converted to i1 when in function's argument/return values.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
Implements calling convention lowering of bool arguments and return value calling conventions for X86_64 and AArch64. For x86_64, this is a bit of an odd case. In the orignal codegen bools are represented as i8 everywhere, except for function arguments/return values. In CIR, we don't allow i1 types, so bools are still represented as `cir.bool` when in functions. However, when lowering to LLVM Dialect, we need to ensure bools will be converted to i1 when in function's argument/return values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements calling convention lowering of bool arguments and return value calling conventions for X86_64 and AArch64.
For x86_64, this is a bit of an odd case. In the orignal codegen bools are represented as i8 everywhere, except for function arguments/return values. In CIR, we don't allow i1 types, so bools are still represented as
cir.boolwhen in functions. However, when lowering to LLVM Dialect, we need to ensure bools will be converted to i1 when in function's argument/return values.