[CIR] Atomic builtins with non-const memory order #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix llvm#731 Implement atomic built-in operations where the memory order argument is a runtime value rather than a compile-time constant. This is necessary to support std::atomic. The ClangIR atomic operations don't support runtime memory orders, so this is implemented during CodeGen by generating a switch statement that effectively converts the runtime memory order into a compile-time memory order. A new file, atomic-runtime.cpp, was added to the ClangIR CodeGen tests to cover this situation.
bcardosolopes
requested changes
Jul 13, 2024
This is the response to code review comments for PR llvm#736. Don't use `auto` declarations in a couple places. Add a test for LLVM lowering of atomic_load_n with a non-const memory order.
bcardosolopes
approved these changes
Jul 15, 2024
bcardosolopes
requested changes
Jul 15, 2024
Change the lowering test atomic-runtime.cpp to check the LLVM IR rather than the LLVM MLIR dialect. LLVM IR will be more stable over time.
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
Fix llvm#731 Implement atomic built-in operations where the memory order argument is a runtime value rather than a compile-time constant. This is necessary to support `std::atomic`. The ClangIR atomic operations don't support runtime memory orders, so this is implemented during CodeGen by generating a switch statement that effectively converts the runtime memory order into a compile-time memory order. A new file, atomic-runtime.cpp, was added to the ClangIR CodeGen tests to cover this situation.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
Fix llvm#731 Implement atomic built-in operations where the memory order argument is a runtime value rather than a compile-time constant. This is necessary to support `std::atomic`. The ClangIR atomic operations don't support runtime memory orders, so this is implemented during CodeGen by generating a switch statement that effectively converts the runtime memory order into a compile-time memory order. A new file, atomic-runtime.cpp, was added to the ClangIR CodeGen tests to cover this situation.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
Fix llvm#731 Implement atomic built-in operations where the memory order argument is a runtime value rather than a compile-time constant. This is necessary to support `std::atomic`. The ClangIR atomic operations don't support runtime memory orders, so this is implemented during CodeGen by generating a switch statement that effectively converts the runtime memory order into a compile-time memory order. A new file, atomic-runtime.cpp, was added to the ClangIR CodeGen tests to cover this situation.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
Fix llvm#731 Implement atomic built-in operations where the memory order argument is a runtime value rather than a compile-time constant. This is necessary to support `std::atomic`. The ClangIR atomic operations don't support runtime memory orders, so this is implemented during CodeGen by generating a switch statement that effectively converts the runtime memory order into a compile-time memory order. A new file, atomic-runtime.cpp, was added to the ClangIR CodeGen tests to cover this situation.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
Fix #731 Implement atomic built-in operations where the memory order argument is a runtime value rather than a compile-time constant. This is necessary to support `std::atomic`. The ClangIR atomic operations don't support runtime memory orders, so this is implemented during CodeGen by generating a switch statement that effectively converts the runtime memory order into a compile-time memory order. A new file, atomic-runtime.cpp, was added to the ClangIR CodeGen tests to cover this situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #731
Implement atomic built-in operations where the memory order argument is a runtime value rather than a compile-time constant. This is necessary to support
std::atomic. The ClangIR atomic operations don't support runtime memory orders, so this is implemented during CodeGen by generating a switch statement that effectively converts the runtime memory order into a compile-time memory order.A new file, atomic-runtime.cpp, was added to the ClangIR CodeGen tests to cover this situation.