New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][CIRGen][LowerToLLVM] Support address space casting #652

Merged

bcardosolopes merged 14 commits into llvm:main from seven-mile:addrspace-cast

Jun 6, 2024

Collaborator

seven-mile commented Jun 2, 2024

New CastKind::addrspace_cast for cir.cast
TargetCIRGenInfo::performAddrSpaceCast helper for non-constant values only
CIRGen for address space casting of pointers and references
Lowering to LLVM

Collaborator Author

seven-mile commented Jun 2, 2024 •

edited

Loading

Note that other versions of TargetCIRGenInfo::performAddrSpaceCast should include GlobalOp and ConstOp, which are unified as llvm::Constant in LLVM IR. Should track it by another issue.

seven-mile commented

View reviewed changes

clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp Show resolved Hide resolved

clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp Show resolved Hide resolved

clang/lib/CIR/CodeGen/CIRGenExpr.cpp Outdated Show resolved Hide resolved

clang/lib/CIR/Dialect/IR/CIRDialect.cpp Outdated Show resolved Hide resolved

Naghasan reviewed

View reviewed changes

clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp Show resolved Hide resolved

clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp Show resolved Hide resolved

bcardosolopes requested changes

View reviewed changes

Member

bcardosolopes left a comment

Overall looks good, more inline comments!

clang/include/clang/CIR/Dialect/IR/CIROps.td Outdated Show resolved Hide resolved

clang/test/CIR/IR/cast.cir Outdated Show resolved Hide resolved

clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp Show resolved Hide resolved

clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp Show resolved Hide resolved

clang/lib/CIR/Dialect/IR/CIRDialect.cpp Outdated Show resolved Hide resolved

seven-mile added 10 commits

June 4, 2024 15:00


          [CIR][Dialect] Add CK_AddressSpaceConversion in cir.cast

9197f76


          [CIR][CodeGen] Add performAddrSpaceCast helper in TargetInfo class

ad2f710


          [CIR][NFC] Verification of new addrspace cast op

fe0e6fc


          [CIR][CIRGen] AddrSpace casting for pointers and references

5ec85df


          [CIR][LowerToLLVM] Lowering of addrspace cast

35fcaab


          [CIR][NFC] Add tests for IR

fb15a47


          [CIR][NFC] Fix after rebase

b81a2a2


          [CIR][NFC] Symplify addrspace_cast to address_space

a22de75


          [CIR][Transforms] Add folding for addrspace cast

a23f9ed


          [CIR][NFC] Add negative test cases for verifier

71e72a9

seven-mile force-pushed the addrspace-cast branch from 869d2bf to 71e72a9 Compare

June 4, 2024 08:19

Collaborator Author

seven-mile commented Jun 4, 2024

Rebased. Updated except ABI-related nullptr representation.

bcardosolopes reviewed

View reviewed changes

clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h Outdated Show resolved Hide resolved

clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp Show resolved Hide resolved

seven-mile added 2 commits

June 6, 2024 12:34


          fix builder

75cbadf


          mark targetCodeGenInfoGetNullPointer

be1baf1

Collaborator Author

seven-mile commented Jun 6, 2024

Updated as suggested.

seven-mile added 2 commits

June 6, 2024 17:22


          fix misplaced feature flag

6f6e8ae

fix

73293ef

bcardosolopes approved these changes

View reviewed changes

Member

bcardosolopes left a comment

Awesome, LGTM

bcardosolopes merged commit 5b44dd7 into llvm:main

6 checks passed

seven-mile mentioned this pull request

[CIR][CodeGen] Support side effects in address space casting #673

Merged

bcardosolopes pushed a commit that referenced this pull request


          [CIR][CodeGen] Support side effects in address space casting (#673)

f78f9a5

Continue the work of #652 . Test the branch of null pointer expressions
with side effects.

seven-mile mentioned this pull request

[GSoC] Add OpenCL support to compile GPU kernels #689

Closed

bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request


          [CIR][CIRGen][LowerToLLVM] Support address space casting (llvm#652)

6ea568e

* New `CastKind::addrspace_cast` for `cir.cast`
* `TargetCIRGenInfo::performAddrSpaceCast` helper for non-constant
values only
* CIRGen for address space casting of pointers and references
* Lowering to LLVM

bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request


          [CIR][CodeGen] Support side effects in address space casting (llvm#673)

82267a4

Continue the work of llvm#652 . Test the branch of null pointer expressions
with side effects.

Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request


          [CIR][CIRGen][LowerToLLVM] Support address space casting (llvm#652)

b13b0bc

* New `CastKind::addrspace_cast` for `cir.cast`
* `TargetCIRGenInfo::performAddrSpaceCast` helper for non-constant
values only
* CIRGen for address space casting of pointers and references
* Lowering to LLVM

Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request


          [CIR][CodeGen] Support side effects in address space casting (llvm#673)

865ffd0

Continue the work of llvm#652 . Test the branch of null pointer expressions
with side effects.

smeenai pushed a commit to smeenai/clangir that referenced this pull request


          [CIR][CIRGen][LowerToLLVM] Support address space casting (llvm#652)

0e97c77

* New `CastKind::addrspace_cast` for `cir.cast`
* `TargetCIRGenInfo::performAddrSpaceCast` helper for non-constant
values only
* CIRGen for address space casting of pointers and references
* Lowering to LLVM

smeenai pushed a commit to smeenai/clangir that referenced this pull request


          [CIR][CodeGen] Support side effects in address space casting (llvm#673)

66b9503

Continue the work of llvm#652 . Test the branch of null pointer expressions
with side effects.

keryell pushed a commit to keryell/clangir that referenced this pull request


          [CIR][CIRGen][LowerToLLVM] Support address space casting (llvm#652)

58d458f

* New `CastKind::addrspace_cast` for `cir.cast`
* `TargetCIRGenInfo::performAddrSpaceCast` helper for non-constant
values only
* CIRGen for address space casting of pointers and references
* Lowering to LLVM

keryell pushed a commit to keryell/clangir that referenced this pull request


          [CIR][CodeGen] Support side effects in address space casting (llvm#673)

16d736f

Continue the work of llvm#652 . Test the branch of null pointer expressions
with side effects.

lanza pushed a commit that referenced this pull request


          [CIR][CIRGen][LowerToLLVM] Support address space casting (#652)

73e2f1a

* New `CastKind::addrspace_cast` for `cir.cast`
* `TargetCIRGenInfo::performAddrSpaceCast` helper for non-constant
values only
* CIRGen for address space casting of pointers and references
* Lowering to LLVM

lanza pushed a commit that referenced this pull request


          [CIR][CodeGen] Support side effects in address space casting (#673)

Continue the work of #652 . Test the branch of null pointer expressions
with side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet