Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CodeGen] Get rid of ZeroInitConstOp #646

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

ivanmurashko
Copy link
Contributor

mlir::cir::ZeroInitConstOp was replaced with llvm.mlir.zero

resolves #627

mlir::cir::ZeroInitConstOp was replaced with llvm.mlir.zero

resolves [llvm#627](llvm#627)
@ivanmurashko
Copy link
Contributor Author

Ping @bcardosolopes for review

@ivanmurashko ivanmurashko changed the title [CIR][CodeGen] Get rid of GZeroInitConstOp [CIR][CodeGen] Get rid of ZeroInitConstOp May 31, 2024
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after you remove the test!

clang/test/CIR/Translation/zeroinitializer.cir Outdated Show resolved Hide resolved
@bcardosolopes bcardosolopes merged commit e16048a into llvm:main Jun 3, 2024
6 checks passed
@ivanmurashko ivanmurashko deleted the get_rid_of_zeroinit branch August 4, 2024 11:08
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
mlir::cir::ZeroInitConstOp was replaced with llvm.mlir.zero

resolves [llvm#627](llvm#627)
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
mlir::cir::ZeroInitConstOp was replaced with llvm.mlir.zero

resolves [llvm#627](llvm#627)
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
mlir::cir::ZeroInitConstOp was replaced with llvm.mlir.zero

resolves [llvm#627](llvm#627)
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
mlir::cir::ZeroInitConstOp was replaced with llvm.mlir.zero

resolves [llvm#627](llvm#627)
lanza pushed a commit that referenced this pull request Nov 5, 2024
mlir::cir::ZeroInitConstOp was replaced with llvm.mlir.zero

resolves [#627](#627)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LLVM IR dialect already supports zeroinitializer, get rid of ZeroInitConstOp
2 participants