[CIR][ThroughMLIR] lowering cir.bit.clz and cir.bit.ctz to MLIR #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lancern
requested changes
May 31, 2024
Comment on lines
428
to
438
| matchAndRewrite(mlir::cir::BitCtzOp op, OpAdaptor adaptor, | ||
| mlir::ConversionPatternRewriter &rewriter) const override { | ||
| auto resultIntTy = | ||
| getTypeConverter()->convertType(op.getType()).cast<mlir::IntegerType>(); | ||
| auto ctz = rewriter.create<mlir::math::CountTrailingZerosOp>( | ||
| op->getLoc(), adaptor.getInput()); | ||
| auto newOp = createIntCast(rewriter, ctz->getResult(0), resultIntTy, | ||
| /*isSigned=*/false); | ||
| rewriter.replaceOp(op, newOp); | ||
| return mlir::LogicalResult::success(); | ||
| } |
There was a problem hiding this comment.
These two matchAndRewrite functions looks similar. Could you refactor out a common matchAndRewriteBitOp function to do the common job? You can reuse this function in later PRs when you try to lower other bit operations.
There was a problem hiding this comment.
Sounds good, I will do that right away.
bcardosolopes
approved these changes
May 31, 2024
| @@ -0,0 +1,94 @@ | |||
| // RUN: cir-opt %s -cir-to-mlir -o %t.mlir | |||
| // RUN: FileCheck %s --input-file %t.mlir | |||
There was a problem hiding this comment.
In your next PRs can you please start writing these from source? You can use -fno-clangir-direct-lowering
There was a problem hiding this comment.
Ok, I'll rewrite bit.cir to bit.c
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
…#645) This pr adds cir.bit.clz and cir.bit.ctz lowering to MLIR passes and test files. I will complete the lowering of other `cir.bit` operations in subsequent PRs.
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
…#645) This pr adds cir.bit.clz and cir.bit.ctz lowering to MLIR passes and test files. I will complete the lowering of other `cir.bit` operations in subsequent PRs.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
…#645) This pr adds cir.bit.clz and cir.bit.ctz lowering to MLIR passes and test files. I will complete the lowering of other `cir.bit` operations in subsequent PRs.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
…#645) This pr adds cir.bit.clz and cir.bit.ctz lowering to MLIR passes and test files. I will complete the lowering of other `cir.bit` operations in subsequent PRs.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
This pr adds cir.bit.clz and cir.bit.ctz lowering to MLIR passes and test files. I will complete the lowering of other `cir.bit` operations in subsequent PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds cir.bit.clz and cir.bit.ctz lowering to MLIR passes and test files.
I will complete the lowering of other
cir.bitoperations in subsequent PRs.