Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CodeGen][Bugfix] fixes volatile structs copy #623

Merged
merged 2 commits into from
May 24, 2024

Conversation

gitoleg
Copy link
Collaborator

@gitoleg gitoleg commented May 22, 2024

This PR fixes a fail on llvm_unreachable for the next case:

volatile A vol_a;
A foo7() {
  return vol_a;
}

Basically, it's just a copy-pasta from the original code-gen.
Also, I added the isVolatile attribute for the cit.copy operation

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM

@bcardosolopes bcardosolopes merged commit c3540b3 into llvm:main May 24, 2024
6 checks passed
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
This PR fixes a fail on `llvm_unreachable`  for the next case:
``` 
volatile A vol_a;
A foo7() {
  return vol_a;
}
```
Basically, it's just a copy-pasta from the original `code-gen`. 
Also, I added the `isVolatile` attribute for the `cit.copy` operation
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
This PR fixes a fail on `llvm_unreachable`  for the next case:
``` 
volatile A vol_a;
A foo7() {
  return vol_a;
}
```
Basically, it's just a copy-pasta from the original `code-gen`. 
Also, I added the `isVolatile` attribute for the `cit.copy` operation
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
This PR fixes a fail on `llvm_unreachable`  for the next case:
``` 
volatile A vol_a;
A foo7() {
  return vol_a;
}
```
Basically, it's just a copy-pasta from the original `code-gen`. 
Also, I added the `isVolatile` attribute for the `cit.copy` operation
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
This PR fixes a fail on `llvm_unreachable`  for the next case:
``` 
volatile A vol_a;
A foo7() {
  return vol_a;
}
```
Basically, it's just a copy-pasta from the original `code-gen`. 
Also, I added the `isVolatile` attribute for the `cit.copy` operation
lanza pushed a commit that referenced this pull request Nov 5, 2024
This PR fixes a fail on `llvm_unreachable`  for the next case:
``` 
volatile A vol_a;
A foo7() {
  return vol_a;
}
```
Basically, it's just a copy-pasta from the original `code-gen`. 
Also, I added the `isVolatile` attribute for the `cit.copy` operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants