[CIR][CodeGen][Bugfix] store fptr of a function with no args #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
This PR fixes the next bug showed in the example below:
```
typedef int (*fn_t)();
int get42() { return 42; }
void foo() {
fn_t f = get42;
}
```
The function type `fn_t` is generated as the variadic one due to no arg
types listed, this is the `codegen` feature. And once we store the
function pointer to a real function - a pointer to `get42` here has the
expected `i32 ()*` type - we get a verification error, so `bitcast` is
needed. The original `codegen` doesn't have it because of opaque
pointers used, and had the `bitcast` earlier, long time ago:
```
%f = alloca i32 (...)*
store i32 (...)* bitcast (i32 ()* @GET42 to i32 (...)*), i32 (...)** %f
```
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
This PR fixes the next bug showed in the example below:
```
typedef int (*fn_t)();
int get42() { return 42; }
void foo() {
fn_t f = get42;
}
```
The function type `fn_t` is generated as the variadic one due to no arg
types listed, this is the `codegen` feature. And once we store the
function pointer to a real function - a pointer to `get42` here has the
expected `i32 ()*` type - we get a verification error, so `bitcast` is
needed. The original `codegen` doesn't have it because of opaque
pointers used, and had the `bitcast` earlier, long time ago:
```
%f = alloca i32 (...)*
store i32 (...)* bitcast (i32 ()* @GET42 to i32 (...)*), i32 (...)** %f
```
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
This PR fixes the next bug showed in the example below:
```
typedef int (*fn_t)();
int get42() { return 42; }
void foo() {
fn_t f = get42;
}
```
The function type `fn_t` is generated as the variadic one due to no arg
types listed, this is the `codegen` feature. And once we store the
function pointer to a real function - a pointer to `get42` here has the
expected `i32 ()*` type - we get a verification error, so `bitcast` is
needed. The original `codegen` doesn't have it because of opaque
pointers used, and had the `bitcast` earlier, long time ago:
```
%f = alloca i32 (...)*
store i32 (...)* bitcast (i32 ()* @GET42 to i32 (...)*), i32 (...)** %f
```
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
This PR fixes the next bug showed in the example below:
```
typedef int (*fn_t)();
int get42() { return 42; }
void foo() {
fn_t f = get42;
}
```
The function type `fn_t` is generated as the variadic one due to no arg
types listed, this is the `codegen` feature. And once we store the
function pointer to a real function - a pointer to `get42` here has the
expected `i32 ()*` type - we get a verification error, so `bitcast` is
needed. The original `codegen` doesn't have it because of opaque
pointers used, and had the `bitcast` earlier, long time ago:
```
%f = alloca i32 (...)*
store i32 (...)* bitcast (i32 ()* @GET42 to i32 (...)*), i32 (...)** %f
```
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
This PR fixes the next bug showed in the example below:
```
typedef int (*fn_t)();
int get42() { return 42; }
void foo() {
fn_t f = get42;
}
```
The function type `fn_t` is generated as the variadic one due to no arg
types listed, this is the `codegen` feature. And once we store the
function pointer to a real function - a pointer to `get42` here has the
expected `i32 ()*` type - we get a verification error, so `bitcast` is
needed. The original `codegen` doesn't have it because of opaque
pointers used, and had the `bitcast` earlier, long time ago:
```
%f = alloca i32 (...)*
store i32 (...)* bitcast (i32 ()* @GET42 to i32 (...)*), i32 (...)** %f
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the next bug showed in the example below:
The function type
fn_tis generated as the variadic one due to no arg types listed, this is thecodegenfeature. And once we store the function pointer to a real function - a pointer toget42here has the expectedi32 ()*type - we get a verification error, sobitcastis needed. The originalcodegendoesn't have it because of opaque pointers used, and had thebitcastearlier, long time ago: