[CIR] Move CIRDataLayout.h into include/clang/CIR/Dialect/IR #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
requested changes
May 21, 2024
| @@ -12,7 +12,6 @@ | |||
| #ifndef LLVM_CLANG_LIB_CIR_CIRDATALAYOUT_H | |||
| #define LLVM_CLANG_LIB_CIR_CIRDATALAYOUT_H | |||
There was a problem hiding this comment.
You need to change the header guards too: LLVM_CLANG_CIR_DIALECT_IR_CIRDATALAYOUT_H
bcardosolopes
changed the title
|
I also updated the title and description |
bcardosolopes
approved these changes
May 21, 2024
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
Move it up for visibility, just like the other dialect headers.
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
Move it up for visibility, just like the other dialect headers.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
Move it up for visibility, just like the other dialect headers.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
Move it up for visibility, just like the other dialect headers.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
Move it up for visibility, just like the other dialect headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move it up for visibility, just like the other dialect headers.