[CIR][CIRGen][LLVMLowering] Add support for checked arithmetic builtins #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lancern
changed the title
bcardosolopes
requested changes
Apr 25, 2024
Lancern
force-pushed
the
builtins-overflow-cirgen
branch
from
b481a25 to
5dc8797
Compare
|
Rebased onto the latest |
Lancern
force-pushed
the
builtins-overflow-cirgen
branch
from
5dc8797 to
39c7765
Compare
|
Rebased onto the latest |
lanza
force-pushed
the
main
branch
2 times, most recently
from
c4db6d0 to
e197d4e
Compare
This patch adds CIRGen support for checked arithmetic builtins, including:
- `__builtin_add_overflow` and `__builtin_{s|u}add{|l|ll}_overflow`;
- `__builtin_sub_overflow` and `__builtin_{s|u}sub{|l|ll}_overflow`;
- `__builtin_mul_overflow` and `__builtin_{s|u}mul{|l|ll}_overflow`.
This patch adds a new operation `cir.binop.overflow` to represent these
builtins. Unlike other CIR operations, this new operation has two result values.
One for the possibly truncated result, and the other for a boolean flag that
indicates whether the operation has overflowed.
Lancern
force-pushed
the
builtins-overflow-cirgen
branch
from
39c7765 to
8ef5113
Compare
|
Rebased onto the latest |
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
…ns (llvm#560) This patch adds support for checked arithmetic builtins, including: - `__builtin_add_overflow` and `__builtin_{s|u}add{|l|ll}_overflow`; - `__builtin_sub_overflow` and `__builtin_{s|u}sub{|l|ll}_overflow`; - `__builtin_mul_overflow` and `__builtin_{s|u}mul{|l|ll}_overflow`. This patch adds a new operation `cir.checked_arith` to represent these builtins. Unlike other CIR operations, this new operation has two result values. One for the possibly truncated result, and the other for a boolean flag that indicates whether the operation has overflowed. CIRGen and LLVMIR lowering support for the new operation is both included in this PR.
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
…ns (llvm#560) This patch adds support for checked arithmetic builtins, including: - `__builtin_add_overflow` and `__builtin_{s|u}add{|l|ll}_overflow`; - `__builtin_sub_overflow` and `__builtin_{s|u}sub{|l|ll}_overflow`; - `__builtin_mul_overflow` and `__builtin_{s|u}mul{|l|ll}_overflow`. This patch adds a new operation `cir.checked_arith` to represent these builtins. Unlike other CIR operations, this new operation has two result values. One for the possibly truncated result, and the other for a boolean flag that indicates whether the operation has overflowed. CIRGen and LLVMIR lowering support for the new operation is both included in this PR.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
…ns (llvm#560) This patch adds support for checked arithmetic builtins, including: - `__builtin_add_overflow` and `__builtin_{s|u}add{|l|ll}_overflow`; - `__builtin_sub_overflow` and `__builtin_{s|u}sub{|l|ll}_overflow`; - `__builtin_mul_overflow` and `__builtin_{s|u}mul{|l|ll}_overflow`. This patch adds a new operation `cir.checked_arith` to represent these builtins. Unlike other CIR operations, this new operation has two result values. One for the possibly truncated result, and the other for a boolean flag that indicates whether the operation has overflowed. CIRGen and LLVMIR lowering support for the new operation is both included in this PR.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
…ns (#560) This patch adds support for checked arithmetic builtins, including: - `__builtin_add_overflow` and `__builtin_{s|u}add{|l|ll}_overflow`; - `__builtin_sub_overflow` and `__builtin_{s|u}sub{|l|ll}_overflow`; - `__builtin_mul_overflow` and `__builtin_{s|u}mul{|l|ll}_overflow`. This patch adds a new operation `cir.checked_arith` to represent these builtins. Unlike other CIR operations, this new operation has two result values. One for the possibly truncated result, and the other for a boolean flag that indicates whether the operation has overflowed. CIRGen and LLVMIR lowering support for the new operation is both included in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for checked arithmetic builtins, including:
__builtin_add_overflowand__builtin_{s|u}add{|l|ll}_overflow;__builtin_sub_overflowand__builtin_{s|u}sub{|l|ll}_overflow;__builtin_mul_overflowand__builtin_{s|u}mul{|l|ll}_overflow.This patch adds a new operation
cir.checked_arithto represent these builtins. Unlike other CIR operations, this new operation has two result values. One for the possibly truncated result, and the other for a boolean flag that indicates whether the operation has overflowed.CIRGen and LLVMIR lowering support for the new operation is both included in this PR.