Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR] Data member pointer comparison and casts #1268

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

Lancern
Copy link
Member

@Lancern Lancern commented Jan 5, 2025

This PR adds CIRGen and LLVM lowering support for the following language features related to pointers to data members:

  • Comparisons between pointers to data members.
  • Casting from pointers to data members to boolean.
  • Reinterpret casts between pointers to data members.

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just need some minor conflict updates!

This patch adds CIRGen and LLVM lowering support for the following language
features related to pointers to data members:

  - Comparisons between pointers to data members.
  - Casting from pointers to data members to boolean.
  - Reinterpret casts between pointers to data members.
@Lancern
Copy link
Member Author

Lancern commented Jan 15, 2025

Conflict resolved.

@bcardosolopes bcardosolopes merged commit 0ae5000 into llvm:main Jan 15, 2025
6 checks passed
@Lancern Lancern deleted the data-member-ops branch January 16, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants