-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIR][CIRGen] Support __builtin_memset_inline #1114
Conversation
This patch depends on the upstream patch from llvm/llvm-project#115711. We can proceed with this PR once the ClangIR has been rebased. @ghehg might be interested in these intrinsics, so please feel free to share your thoughts! |
LGTM, Thanks for working on this, especially for adding LLVM::MemsetInlineOp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it cherry-picks cleanly, we could also potentially cherry-pick llvm/llvm-project#115711, and it'll just get rebased out on the next rebase. |
I'm ok with that too, good point. Should we tag the title in any specific way? @PikachuHyA if you want to cherry-pick the dep, put a separate PR for that one and we land this after that! |
Maybe |
sent #1135 |
Merged! |
74c2c64
to
4d3b799
Compare
No description provided.