Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CIRGen] Support __builtin_memset_inline #1114

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

PikachuHyA
Copy link
Collaborator

No description provided.

@PikachuHyA
Copy link
Collaborator Author

This patch depends on the upstream patch from llvm/llvm-project#115711.

We can proceed with this PR once the ClangIR has been rebased.

@ghehg might be interested in these intrinsics, so please feel free to share your thoughts!

@ghehg ghehg self-requested a review November 13, 2024 13:34
@ghehg
Copy link
Collaborator

ghehg commented Nov 13, 2024

LGTM, Thanks for working on this, especially for adding LLVM::MemsetInlineOp

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I'd suggest you break this PR into everything but LLVM lowering (you can emit a op.emitError() for now) so we land CIRGen faster, once we rebase you add the lowering bits, how does that sound? @lanza is out on vacation, so I don't expect any rebase in the next two weeks (cc @smeenai)

clang/test/CIR/CodeGen/builtins-memory.c Show resolved Hide resolved
@smeenai
Copy link
Collaborator

smeenai commented Nov 13, 2024

If it cherry-picks cleanly, we could also potentially cherry-pick llvm/llvm-project#115711, and it'll just get rebased out on the next rebase.

@bcardosolopes
Copy link
Member

bcardosolopes commented Nov 13, 2024

If it cherry-picks cleanly, we could also potentially cherry-pick llvm/llvm-project#115711, and it'll just get rebased out on the next rebase.

I'm ok with that too, good point. Should we tag the title in any specific way? @PikachuHyA if you want to cherry-pick the dep, put a separate PR for that one and we land this after that!

@smeenai
Copy link
Collaborator

smeenai commented Nov 13, 2024

If it cherry-picks cleanly, we could also potentially cherry-pick llvm/llvm-project#115711, and it'll just get rebased out on the next rebase.

I'm ok with that too, good point. Should we tag the title in any specific way? @PikachuHyA if you want to cherry-pick the dep, put a separate PR for that one and we land this after that!

Maybe [upstream] or [cherry-pick], plus using git cherry-pick -x so that the commit message includes the original hash.

@PikachuHyA
Copy link
Collaborator Author

If it cherry-picks cleanly, we could also potentially cherry-pick llvm/llvm-project#115711, and it'll just get rebased out on the next rebase.

I'm ok with that too, good point. Should we tag the title in any specific way? @PikachuHyA if you want to cherry-pick the dep, put a separate PR for that one and we land this after that!

Maybe [upstream] or [cherry-pick], plus using git cherry-pick -x so that the commit message includes the original hash.

sent #1135

@bcardosolopes
Copy link
Member

Merged!

@PikachuHyA PikachuHyA force-pushed the support_memset_inline_v3 branch from 74c2c64 to 4d3b799 Compare November 19, 2024 02:14
@bcardosolopes bcardosolopes merged commit affa8f8 into llvm:main Nov 19, 2024
6 checks passed
@PikachuHyA PikachuHyA deleted the support_memset_inline_v3 branch November 20, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants