[CIR][CIRGen] Removed extra space in "cir.shift( right)" (#997) #1009
Conversation
There was a problem hiding this comment.
Thanks, this is a great catch!
The example in https://mlir.llvm.org/docs/DefiningDialects/Operations/#optional-else-group shows no spaces around the colon. Does that also work to remove the space here?
If it doesn't and you have to keep the diff as-is, could you link to https://mlir.llvm.org/docs/DefiningDialects/Operations/#literals in your PR description and quote the part about the meaning of an empty literal? That way people like me who aren't as familiar with ODS will be able to understand this change easily :)
Thanks for your comments! Thanks for your suggestion, I'll definitely update the PR description to make the reasoning behind the change clearer. |
The MLIR docs at https://mlir.llvm.org/docs/DefiningDialects/Operations/#literals specify that "An empty literal `` may be used to remove a space that is inserted implicitly after certain literal elements", so I inserted one before the `right` literal to remove the extra space that was being printed. Oddly, the bug is also fixed by inserting an empty literal _after_ the `left` literal, which leads me to believe that tablegen is inserting an implicit space after the `left` literal.
…1096) Following #1009 and #1028, this PR removes the double white spaces in the assembly format of `cir.global` op. It's basically some `mlir-tablegen`-builtin magic: With `constBuilderCall` specified, we can apply `DefaultValuedAttr` with any default value we can construct from constant values. Then we can easily omit the default in assembly. Hence, we don't need to compromise anything for the wrapper attribute `cir::VisibilityAttr`. Similarly to #1009, an empty literal ``` `` ``` is used to omit the leading space emitted by inner attribute. The test case `visibility-attribute.c` is modified to save the intermediate CIR to disk and reflect the effects. Double whitespaces in other test files are removed.
The MLIR docs at https://mlir.llvm.org/docs/DefiningDialects/Operations/#literals specify that "An empty literal `` may be used to remove a space that is inserted implicitly after certain literal elements", so I inserted one before the
rightliteral to remove the extra space that was being printed. Oddly, the bug is also fixed by inserting an empty literal after the `left` literal, which leads me to believe that tablegen is inserting an implicit space after the `left` literal.