-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIR][ABI][AArch64][Lowering] Initial support for return of struct types #1004
Conversation
✅ With the latest revision this PR passed the C/C++ code formatter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took a while, LLVM Dev meeting this week got us all busy.
This looks almost good, just some missing feature asserts needed
clang/lib/CIR/Dialect/Transforms/TargetLowering/Targets/AArch64.cpp
Outdated
Show resolved
Hide resolved
clang/lib/CIR/Dialect/Transforms/TargetLowering/Targets/AArch64.cpp
Outdated
Show resolved
Hide resolved
@bcardosolopes done, added missing features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will merge once format issues from buildbots are fixed + minor render script removal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it's also failing lit tests, marking this as needing changes
…pes (#1004) This PR adds a support for return values of a struct type. There are two cases that are not covered by this PR and will be added later.
This PR adds a support for return values of a struct type. There are two cases that are not covered by this PR and will be added later.