Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][ABI][AArch64][Lowering] Initial support for return of struct types #1004

Merged
merged 12 commits into from
Oct 29, 2024

Conversation

gitoleg
Copy link
Collaborator

@gitoleg gitoleg commented Oct 22, 2024

This PR adds a support for return values of a struct type. There are two cases that are not covered by this PR and will be added later.

Copy link

github-actions bot commented Oct 22, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took a while, LLVM Dev meeting this week got us all busy.

This looks almost good, just some missing feature asserts needed

@gitoleg
Copy link
Collaborator Author

gitoleg commented Oct 28, 2024

@bcardosolopes done, added missing features

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once format issues from buildbots are fixed + minor render script removal

clang/include/clang/CIR/MissingFeatures.h Outdated Show resolved Hide resolved
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's also failing lit tests, marking this as needing changes

@bcardosolopes bcardosolopes changed the title [CIR][ABI][AArch64][Lowering] Support retrun values of a struct type. Part 1 [CIR][ABI][AArch64][Lowering] Initial support for return of struct types Oct 28, 2024
@bcardosolopes bcardosolopes merged commit 5873d88 into llvm:main Oct 29, 2024
6 checks passed
lanza pushed a commit that referenced this pull request Nov 5, 2024
…pes (#1004)

This PR adds a support for return values of a struct type. There are two
cases that are not covered by this PR and will be added later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants