Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outputting epub format #233

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Outputting epub format #233

merged 1 commit into from
Apr 26, 2024

Conversation

rommelDB
Copy link
Contributor

@rommelDB rommelDB commented Apr 25, 2024

This PR is the first successful attempt to generate an EPUB book. Next steps would be to customize the cover, improve the quality of the images, styling with CSS, etc. Addresses #211


This change is Reviewable

Copy link
Member

@kbeyls kbeyls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is brilliant, thank you very much!

As you say, there are quite a few further things that probably could be improved after landing this PR, but having an Epub format at all is fantastic!

Next to what you have listed, I'm also thinking of the following "next-step" improvements:
[ ] Make the "TODO" items visible in a reasonable way in the epub format, like they are visible in html (on the side) and in the PDF format.
[ ] Add a button to the website to enable downloading this epub format (and also add download options for downloading the PDF and the HTML versions too)
[ ] The References section is empty in the epub format. Is that a limitation of pandoc, or is there something that could be done to improve how references work in the epub format?

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@kbeyls kbeyls merged commit 254f858 into llsoftsec:main Apr 26, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants