Initialize storage on omni executor startup #3228
Open
+281
−210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kailai-Wang
approved these changes
Jan 10, 2025
| edition.workspace = true | ||
|
|
||
| [dependencies] | ||
| executor-core = { path = "../../executor-core" } |
There was a problem hiding this comment.
Do you consider using workspace dep?
There was a problem hiding this comment.
We probably should. I was just trying to be consistent with what we currently have. I'll update the dependencies 👍🏼
| } | ||
|
|
||
| async fn init_account_store_storage(client: &SubxtClient<CustomConfig>) -> Result<(), ()> { | ||
| let storage_query = parentchain_api_interface::storage().omni_account().account_store_iter(); |
There was a problem hiding this comment.
There's no concept of storage proof right? Like we don't have to verify anything that we downloaded
There was a problem hiding this comment.
Well, it is still available in the legacy modules. The rpc method to get the proofs is there and some types to verify the values. Do you think we need to do this? As long as we connect the worker to a node that we trust its ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As topic, when starting the omni-executor it downloads the AccountStore from the parentchain and saves the in the storage.
Some modules have been reorganized for reuse.