Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick-fix: assertion contracts tests #2924

Merged
merged 7 commits into from
Jul 23, 2024

Conversation

0xverin
Copy link
Contributor

@0xverin 0xverin commented Jul 23, 2024

Context

fix https://github.com/litentry/litentry-parachain/actions/runs/10047804865/job/27782346298

Reason: ts-tests only set one secret when deploying contracts, that when requesting bnb, noderealclient needs to be used,it needs secrets[1], which is out of index of array,that causes the secret to be unable to be decoded when requesting dynamic contracts.

Solution: Adding at least 3 secrets.

@0xverin 0xverin force-pushed the quick-fix-assertion-contracts-tests branch from c829e1c to 61be53a Compare July 23, 2024 04:20
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change file-filter.yml too

@0xverin 0xverin force-pushed the quick-fix-assertion-contracts-tests branch from f5617bd to e58acb4 Compare July 23, 2024 08:17
@0xverin 0xverin requested a review from Kailai-Wang July 23, 2024 08:20
@Kailai-Wang Kailai-Wang merged commit da4792b into dev Jul 23, 2024
32 checks passed
@Kailai-Wang Kailai-Wang deleted the quick-fix-assertion-contracts-tests branch July 23, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants