-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p-866 Adding btc token holding amount #2919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add hardhat tests ?
Okay, that's why I didn't merge after approve. |
...orker/litentry/core/assertion-build/src/dynamic/contracts/token_holding_amount/erc20/Dai.sol
Outdated
Show resolved
Hide resolved
a25a2af
to
562a576
Compare
...orker/litentry/core/assertion-build/src/dynamic/contracts/token_holding_amount/erc20/Cro.sol
Outdated
Show resolved
Hide resolved
7c8dfe5
to
c24e21e
Compare
LGTM, could you pls add some cli test evidence? |
pls see description. |
Does the true case also work? |
Done!
Updated. |
Context
as the topic;
this pr also adding dataprovider client to tokeninfo structure
The CLI test has not passed yet. But it can be reviewed first.
Labels
Please apply following PR-related labels when appropriate:
C0-breaking
: if your change could break the existing client, e.g. API change, critical logic changeC1-noteworthy
: if your change is non-breaking, but is still worth noticing for the client, e.g. reference code improvementHow (Optional)
Testing Evidences