Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: A8 wrong network in VC #2904
fix: A8 wrong network in VC #2904
Changes from 1 commit
07d9e65
c52e851
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you think just add a filter to filter out types, which is NOT
Litentry, Litmus, Polkadot, Kusama, Khala, or Ethereum
?Then we don't need to create a new type
A8SupportedNetwork
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the client pass in the wrong networks? Shouldn't this be fixed at client side first?
But sure we could a second check logic here
And yes we can simply filter out unwanted types, or
retain
only desired onesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kailai-Wang this is the leftover of refactoring of shifting network type from
link_identity
torequest_vc
. From IDHub point of view, they always wish the all supported networks. So they don't do any filtering at client side. We did the magic withinget_eligible_identities()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactored to only filter instead creating new types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt that's related.
The main motivation here was to have a struct to represent exactly the accepted values for A8. Clients must specify one of them to get the right assertion.