Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux fest 2022 #2

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

linux fest 2022 #2

wants to merge 6 commits into from
+31 −7

Conversation

FarshidNooshi
Copy link
Contributor

add systemd & directory structure and edited markdowns of the repository

@FarshidNooshi
Copy link
Contributor Author

@1995parham @theerfan @smf8 @sarb9

@theerfan
Copy link
Member

theerfan commented Apr 8, 2022

Mate why are you mentioning me?
I don't even have write access. :))))

@FarshidNooshi
Copy link
Contributor Author

@theerfan
lol, the github showed you to me as a suggestion for that comment.
maybe we should try to optimize their recommender system as the next project :)

@1995parham
Copy link
Member

I have write access but I think it is better to have review from younger peoples 😂 @amirhnajafiz

@FarshidNooshi
Copy link
Contributor Author

thanks, ok. 😄

ShayanDeSh
ShayanDeSh requested changes Apr 9, 2022
View reviewed changes
Copy link
Member

@ShayanDeSh ShayanDeSh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Farshid,

Firstly, thanks for your great contents. Please take a note of the reviews I mentioned. And what's your idea about merging linux-fest-directory.pptx with amirkabir_linux_festival.pptx as there already exist some description about Linux directories in the later one?

Instructor's notes.md
Most of information are taken from "Introduction to Linux" and "Linux bible" books and following sites: https://www.linuxnix.com/linux-directory-structure-explained-boot-folder/
Most of information are taken from "Introduction to Linux" and "Linux bible" books and following sites:

[first site](https://www.linuxnix.com/linux-directory-structure-explained-boot-folder/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use a better name (Maybe the name of the website itself) for referencing.

Instructor's notes.md

- ### systemd
almost all of the information for systemd are taken from the following webistes:
[first](https://www.linux-magazine.com/Issues/2017/200/Tutorials-Systemd#article_f1)
Copy link
Member

@ShayanDeSh ShayanDeSh Apr 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, use better names here.

@amirhnajafiz
Copy link
Member

@FarshidNooshi
Dear farshid,
fix the change request and then I will merge it into the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShayanDeSh ShayanDeSh ShayanDeSh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FarshidNooshi @theerfan @1995parham @amirhnajafiz @ShayanDeSh