Feature/vars expanding into parameters #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rihter007
force-pushed
the
feature/vars_expanding_into_parameters
branch
from
48979ca to
35fc6f2
Compare
|
Hm, due to merging conflicts the PR looks bulky. |
rihter007
force-pushed
the
feature/vars_expanding_into_parameters
branch
from
78a704b to
0380b8a
Compare
rihter007
commented
Jun 22, 2022
| import ( | ||
| "encoding/json" | ||
| "fmt" | ||
| "github.com/linuxboot/contest/pkg/event/testevent" |
There was a problem hiding this comment.
nit
Imports should be grouped: standard, project, external
|
Can we review this after merging the previous PR? |
Signed-off-by: Ilya <[email protected]>
Add unit tests for CheckVariableName Code-style improvements based on PR's comments Signed-off-by: Ilya <[email protected]>
rihter007
force-pushed
the
feature/vars_expanding_into_parameters
branch
from
0380b8a to
8a56dea
Compare
Signed-off-by: Ilya <[email protected]>
Signed-off-by: Ilya <[email protected]>
Signed-off-by: Ilya <[email protected]>
rihter007
force-pushed
the
feature/vars_expanding_into_parameters
branch
2 times, most recently
from
f2e47dd to
00915fa
Compare
Signed-off-by: Ilya <[email protected]>
Add check that variables refer to existing test steps Signed-off-by: Ilya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## poc/steps_variables #85 +/- ##
=======================================================
+ Coverage 66.46% 66.61% +0.14%
=======================================================
Files 158 159 +1
Lines 9724 9776 +52
=======================================================
+ Hits 6463 6512 +49
+ Misses 2563 2557 -6
- Partials 698 707 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rihter007
force-pushed
the
poc/steps_variables
branch
3 times, most recently
from
1306d17 to
979b7dd
Compare
rihter007
force-pushed
the
poc/steps_variables
branch
from
979b7dd to
9a8efb9
Compare
rihter007
force-pushed
the
poc/steps_variables
branch
2 times, most recently
from
39a8f78 to
8196bfa
Compare
|
Is obsolete, will create a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #25
Added variables plugin that can create variables from parameters
Added e2e test