[duckdb] Operation Foie Gras #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Time to force-feed the duck. Pre-allocated all Avro deserializers,
connection, prepared statement as well as the InsertProcessor, so
that the hot path has as little to do as possible.
Miscellaneous:
- Changed the unhandled type policy from FAIL to SKIP.
- Made DVRT implement Closeable.
- Added a new useUniformInputValueSchema() API to DVRT:
- If false (default), SIT will give whatever incoming record in
the schema it comes in.
- If true (which the DuckDB DVRT does), SIT will use Avro schema
evolution to decode the incoming records into the same schema
which it passed into the DVRT constructor.
kvargha
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time to force-feed the duck. Pre-allocated all Avro deserializers, connection, prepared statement as well as the InsertProcessor, so that the hot path has as little to do as possible.
Miscellaneous:
Changed the unhandled type policy from FAIL to SKIP.
Made DVRT implement Closeable.
Added a new useUniformInputValueSchema() API to DVRT:
If false (default), SIT will give whatever incoming record in the schema it comes in.
If true (which the DuckDB DVRT does), SIT will use Avro schema evolution to decode the incoming records into the same schema which it passed into the DVRT constructor.
Does this PR introduce any user-facing changes?