[controller] Add server-side audit logger for controller gRPC server #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a server-side audit logging interceptor for the controller gRPC server. The `ControllerGrpcAuditLoggingInterceptor` logs details about incoming and outgoing gRPC calls, including the API method name, server address, client address, cluster name, store name, request latency, and response status. Incoming requests are logged with `[AUDIT][gRPC][IN]`, while outgoing responses are logged with `[AUDIT][gRPC][OUT]`. The interceptor gracefully handles cases where metadata or address information is missing. This enhancement improves the observability and auditability of gRPC-based interactions in the Venice Controller.
sushantmane
force-pushed
the
grpc-in-venice-control-plane-audit-logger
branch
from
4390c3f to
5628c83
Compare
This reverts commit bd03b29.
KaiSernLim
approved these changes
Jan 17, 2025
services/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceController.java
Show resolved
Hide resolved
|
Thanks, @KaiSernLim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add server-side audit logger for controller gRPC server
This commit introduces a server-side audit logging interceptor for the controller gRPC
server. The
ControllerGrpcAuditLoggingInterceptorlogs details about incoming andoutgoing gRPC calls, including the API method name, server address, client address,
cluster name, store name, request latency, and response status. Incoming requests are
logged with
[AUDIT][gRPC][IN], while outgoing responses are logged with[AUDIT][gRPC][OUT].How was this PR tested?
UT and E2E
Does this PR introduce any user-facing changes?