[duckdb] Cleanup and refactor DVRT interface to be more configurable #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixGV
reviewed
Jan 16, 2025
clients/da-vinci-client/src/main/java/com/linkedin/davinci/client/DaVinciRecordTransformer.java
Outdated
Show resolved
Hide resolved
...ts/da-vinci-client/src/main/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTask.java
Outdated
Show resolved
Hide resolved
...-vinci-client/src/main/java/com/linkedin/davinci/client/DaVinciRecordTransformerUtility.java
Outdated
Show resolved
Hide resolved
...-vinci-client/src/main/java/com/linkedin/davinci/client/DaVinciRecordTransformerUtility.java
Show resolved
Hide resolved
...-vinci-client/src/main/java/com/linkedin/davinci/client/DaVinciRecordTransformerUtility.java
Show resolved
Hide resolved
clients/da-vinci-client/src/test/java/com/linkedin/davinci/config/DaVinciConfigTest.java
Outdated
Show resolved
Hide resolved
FelixGV
previously approved these changes
Jan 16, 2025
ZacAttack
previously approved these changes
Jan 16, 2025
clients/da-vinci-client/src/main/java/com/linkedin/davinci/client/DaVinciRecordTransformer.java
Show resolved
Hide resolved
FelixGV
previously approved these changes
Jan 16, 2025
ZacAttack
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary, imperative, start upper case, don't end with a period
Previously, the user would have to define the key and output schema inside their DVRT implementation, which wasn't clean. Now, they're moved into the constructor. The user now only needs to provide the output schema, as the key schema will be automatically passed in by DVC.
I also added a constructor parameter for original output schema to support reader/writer schemas, but added a ToDo on how to implement the logic to pass in the correct schema.
Lastly, I make the DuckDB DVRT implementation more configurable, as it was previously more hardcoded.
How was this PR tested?
Does this PR introduce any user-facing changes?
This changes modifies the constructor of DVRT with the intention of making the implementation cleaner.