Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controller] Enforce ACL checks on gRPC createStore API #1443

Merged
merged 3 commits into from
Jan 17, 2025
Merged

[controller] Enforce ACL checks on gRPC createStore API #1443

merged 3 commits into from
Jan 17, 2025

Conversation

sushantmane
Copy link
Collaborator

@sushantmane sushantmane commented Jan 16, 2025 •
edited
Loading

Enforce ACL checks on VeniceControllerGrpcServiceImpl::createStore API

  • Use access controller manager to enforce ACL checks in gRPC createStore API.
  • Add support for running E2E tests with a custom access controller.
  • Introduce GrpcControllerClientDetails to encapsulate gRPC session details for
    authorization checks.

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

@sushantmane sushantmane force-pushed the grpc-in-venice-control-plane-enforce-acl branch from 4fc5200 to 18e20e6 Compare January 16, 2025 02:56
@sushantmane sushantmane changed the title [controller] Enforce ACL checks on VeniceControllerGrpcServiceImpl::createStore API [controller] Enforce ACL checks on gRPC createStore API Jan 16, 2025
@sushantmane sushantmane marked this pull request as ready for review January 16, 2025 02:59
@sushantmane sushantmane enabled auto-merge (squash) January 16, 2025 03:04
majisourav99
majisourav99 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@majisourav99 majisourav99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sushantmane sushantmane merged commit fbbd13b into linkedin:main Jan 17, 2025
56 checks passed
@sushantmane
Copy link
Collaborator Author

Thanks, @majisourav99!

@sushantmane sushantmane deleted the grpc-in-venice-control-plane-enforce-acl branch January 17, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majisourav99 majisourav99 majisourav99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sushantmane @majisourav99