[server] Add host-level signals for adaptive ingestion throttler #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...nci-client/src/main/java/com/linkedin/davinci/kafka/consumer/AdaptiveThrottlerSignalHub.java
Outdated
Show resolved
Hide resolved
...client/src/main/java/com/linkedin/davinci/kafka/consumer/AdaptiveThrottlerSignalService.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/linkedin/davinci/stats/ingestion/heartbeat/HeartbeatMonitoringService.java
Outdated
Show resolved
Hide resolved
...client/src/main/java/com/linkedin/davinci/kafka/consumer/AdaptiveThrottlerSignalService.java
Outdated
Show resolved
Hide resolved
...ts/da-vinci-client/src/main/java/com/linkedin/davinci/kafka/consumer/IngestionThrottler.java
Outdated
Show resolved
Hide resolved
sixpluszero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[server] Add host-level signals for adaptive ingestion throttler
This PR adds host-level signals for adaptive ingestion throttler, it includes read latency and heartbeat lag signals. This PR also adjust the adaptive signal onboarding to global throttler, instead of the pool throttler, for the simplicity purpose.
It also adjust some setup in throttler implementation, so that after certain time of idleness in signal, it will try to bump up the config.
Current implementation is just a proof of concept, we expect a lot of tuning will happen to make it work properly
How was this PR tested?
Does this PR introduce any user-facing changes?