-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make warmup to respect dual read mode, and separate warmup configs for indis #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohhyang
requested review from
PapaCharlie,
nizarm,
shivamgupta1,
lauraliu61b,
brycezhongqing and
ZoabKapoor
December 22, 2023 22:30
d2/src/main/java/com/linkedin/d2/balancer/util/WarmUpLoadBalancer.java
Outdated
Show resolved
Hide resolved
d2/src/main/java/com/linkedin/d2/balancer/util/WarmUpLoadBalancer.java
Outdated
Show resolved
Hide resolved
bohhyang
changed the title
Make warm-up to respect dual read mode, and separate warmup configs for indis
Make warmup to respect dual read mode, and separate warmup configs for indis
Jan 2, 2024
shivamgupta1
reviewed
Jan 3, 2024
d2/src/main/java/com/linkedin/d2/balancer/dualread/DualReadLoadBalancer.java
Show resolved
Hide resolved
d2/src/main/java/com/linkedin/d2/balancer/dualread/DualReadLoadBalancer.java
Show resolved
Hide resolved
d2/src/main/java/com/linkedin/d2/balancer/util/WarmUpLoadBalancer.java
Outdated
Show resolved
Hide resolved
d2/src/main/java/com/linkedin/d2/balancer/util/WarmUpLoadBalancer.java
Outdated
Show resolved
Hide resolved
d2/src/main/java/com/linkedin/d2/balancer/util/WarmUpLoadBalancer.java
Outdated
Show resolved
Hide resolved
shivamgupta1
reviewed
Jan 4, 2024
d2/src/main/java/com/linkedin/d2/balancer/util/WarmUpLoadBalancer.java
Outdated
Show resolved
Hide resolved
shivamgupta1
reviewed
Jan 4, 2024
d2/src/test/java/com/linkedin/d2/balancer/util/WarmUpLoadBalancerTest.java
Outdated
Show resolved
Hide resolved
bohhyang
force-pushed
the
boyang/indisWarmup
branch
from
January 4, 2024 18:07
bcdb328
to
929d4ab
Compare
shivamgupta1
approved these changes
Jan 5, 2024
d2/src/test/java/com/linkedin/d2/balancer/util/WarmUpLoadBalancerTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current warmup starts for both ZK and xDS regardless of dual read mode, and the logic of fetching dual read mode (service data) blocks the warmup timeout which fails app startup.
This change:
Testing Done