Translate optional map/arrays with defaults to Avro without breaking #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchen07
reviewed
Dec 14, 2023
| message(path, | ||
| "cannot translate absent optional field (to have null value) because this field is optional and has a default value")); | ||
| DataSchema.Type fieldDefaultValueType = field.getType().getType(); | ||
| // punt on other default values for now (too complex to handle) |
There was a problem hiding this comment.
If we are not handling all cases, what usecases do we unblock?
There was a problem hiding this comment.
The Python Gradle plugin (LI internal) always translates to Avro. I will share the exact PR in Slack.
mchen07
reviewed
Dec 14, 2023
| "cannot translate absent optional field (to have null value) because this field is optional and has a default value")); | ||
| DataSchema.Type fieldDefaultValueType = field.getType().getType(); | ||
| // punt on other default values for now (too complex to handle) | ||
| if (fieldDefaultValueType == DataSchema.Type.UNION || fieldDefaultValueType == DataSchema.Type.RECORD |
There was a problem hiding this comment.
In #133, it already ruled out UNION case? Also for TYPEREF, we should look at dereferencedType?
|
closing for now. will reopen a broader solution later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the translation of default values for optional fields when
TRANSLATE_DEFAULTis enabled. Before, there were cases (especially for nested records) where non-null default values would not be translated. This change enables translating default values (excluding unions, records, and typerefs).