move the log about merged uri properties version

linkedin · Dec 19, 2023 · 798fc17 · 798fc17
1 parent f2a3ca1
commit 798fc17
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/d2/src/main/java/com/linkedin/d2/balancer/properties/UriPropertiesMerger.java b/d2/src/main/java/com/linkedin/d2/balancer/properties/UriPropertiesMerger.java
@@ -45,10 +45,6 @@ public UriProperties merge(String propertyName, Collection<UriProperties> proper
     {
       propertyVersion = property.getVersion();
       maxVersion = Long.max(maxVersion, propertyVersion);
-      if (maxVersion == -1)
-      {
-        _log.warn("Uri properties has invalid version: {}. It should be > -1.", propertyVersion);
-      }
       for (Map.Entry<URI, Map<Integer, PartitionData>> entry : property.getPartitionDesc().entrySet())
       {
         partitionData.put(entry.getKey(), entry.getValue());
@@ -59,6 +55,10 @@ public UriProperties merge(String propertyName, Collection<UriProperties> proper
       }
     }
 
+    if (maxVersion == -1)
+    {
+      _log.warn("Merged Uri properties has invalid version -1. It should be > -1.");
+    }
     return new UriProperties(clusterName, partitionData, uriSpecificProperties, maxVersion);
   }