Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Sync for IdleHandle #2189

Merged
merged 2 commits into from
May 18, 2022
Merged

impl Sync for IdleHandle #2189

merged 2 commits into from
May 18, 2022

Conversation

raphlinus
Copy link
Contributor

Make IdleHandle implement the Sync bound on all platforms. This is required to wrap IdleHandle in any Arc, motivated in particular by ArcWaker which is in turn motivated by async Xilem experiments (see #2184)

Make IdleHandle implement the Sync bound on all platforms. This is required to wrap IdleHandle in any Arc, motivated in particular by ArcWaker which is in turn motivated by async Xilem experiments (see #2184)
@jneem
Copy link
Collaborator

jneem commented May 18, 2022

Could you also add Sync to the assertion at the end of druid-shell/src/window.rs?

@raphlinus raphlinus merged commit 6c72829 into master May 18, 2022
@cmyr cmyr deleted the sync_idle branch June 20, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants