Add validation of Github workflows to pre-commit #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a great addition. Just to be sure, did you confirm that all of our current workflows pass the pre-commit check? |
|
Yes, I created a repository with the latest PPT release just to make sure, and the workflows were validated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new hook to the
pre-commitconfig to validate GitHub workflows. It downloads the schema directly from the GitHub vendor (which is updated periodically) and checks if the schema is compliant. Closes #383.Checklist
lincc-frameworks/python-project-templaterepo and not a downstream one instead.