fix: added missing error messages (#446)

lightning-js · Nov 14, 2024 · 9b7d807 · 9b7d807
2 parents 3119232 + 1d08491
commit 9b7d807
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/src/core/renderers/webgl/WebGlCoreShader.ts b/src/core/renderers/webgl/WebGlCoreShader.ts
@@ -143,12 +143,14 @@ export abstract class WebGlCoreShader extends CoreShader {
       fragmentSource,
     );
     if (!vertexShader || !fragmentShader) {
-      throw new Error();
+      throw new Error(
+        `Unable to create shader type: ${glw.FRAGMENT_SHADER}. Source: ${fragmentSource}`,
+      );
     }
 
     const program = createProgram(glw, vertexShader, fragmentShader);
     if (!program) {
-      throw new Error();
+      throw new Error('Unable to create program');
     }
     this.program = program;
 

diff --git a/src/core/renderers/webgl/internal/ShaderUtils.ts b/src/core/renderers/webgl/internal/ShaderUtils.ts
@@ -100,11 +100,11 @@ export function createShader(
 ) {
   const shader = glw.createShader(type);
   if (!shader) {
-    throw new Error();
+    throw new Error(`Unable to create shader type: ${type}. Source: ${source}`);
   }
   glw.shaderSource(shader, source);
   glw.compileShader(shader);
-  const success = glw.getShaderParameter(shader, glw.COMPILE_STATUS);
+  const success = !!glw.getShaderParameter(shader, glw.COMPILE_STATUS);
   if (success) {
     return shader;
   }
@@ -120,12 +120,13 @@ export function createProgram(
 ) {
   const program = glw.createProgram();
   if (!program) {
-    throw new Error();
+    throw new Error('Unable to create program');
   }
+
   glw.attachShader(program, vertexShader);
   glw.attachShader(program, fragmentShader);
   glw.linkProgram(program);
-  const success = glw.getProgramParameter(program, glw.LINK_STATUS);
+  const success = !!glw.getProgramParameter(program, glw.LINK_STATUS);
   if (success) {
     return program;
   }