misc: implement uv_getrusage_thread #4666
Open
+136
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanarbol
force-pushed
the
juan-james/getrusage
branch
from
cda19f0 to
535f95f
Compare
santigimeno
reviewed
Jan 9, 2025
bnoordhuis
reviewed
Jan 9, 2025
There was a problem hiding this comment.
I believe it's possible to get the relevant info out of xnu with proc_pidinfo(PROC_PIDTHREADID64INFO) and I think (but am not 100% sure) you can obtain the thread id with pthread_threadid_np().
(I wrote some code to that effect years ago but I don't have macOS at hand to test on.)
juanarbol
force-pushed
the
juan-james/getrusage
branch
from
535f95f to
83c222f
Compare
|
This new revision address all your comments and adds support for macOS. |
bnoordhuis
reviewed
Jan 9, 2025
santigimeno
reviewed
Jan 9, 2025
juanarbol
force-pushed
the
juan-james/getrusage
branch
2 times, most recently
from
1f1b9f1 to
b0fcbaf
Compare
santigimeno
reviewed
Jan 9, 2025
juanarbol
force-pushed
the
juan-james/getrusage
branch
from
b0fcbaf to
6a6fd0b
Compare
Refs: libuv#3119 Co-authored-by: Juan José Arboleda <[email protected]> Signed-off-by: Juan José Arboleda <[email protected]>
juanarbol
force-pushed
the
juan-james/getrusage
branch
from
6a6fd0b to
db3f686
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #3119
This is #3120 with all comments addressed and tested on Linux, FreeBSD and macOS