Fix overlay heuristic for GeometryCollections with empty elements #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaston
reviewed
Jan 15, 2025
dr-jts
added a commit
that referenced
this pull request
Jan 17, 2025
dr-jts
added a commit
that referenced
this pull request
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the behaviour of the "combine disjoint" overlay heuristic for GeometryCollections containing empty elements (which are now removed).
Fixes #1224
(Note: part of #1224 requires #1136 to be fixed as well).
The PR also:
HeuristicOverlay(moving code fromGeometry)HeuristicOverlaycodeHeuristicOverlaysemantics to return empty results as an empty typed atomic geometry instead of an empty GeometryCollection (this matchesOverlayNG)HeuristicOverlay(by callingOverlayNGRobustdirectly where it is known the heuristics do not apply)XMLTesterto correctly handle operation A & B argument switching