Unbreak Windows CI builds #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 12.13.x releases of symbolic-demangle result in broken Windows builds. Until that is fixed upstream, make sure that we use a lower version. Signed-off-by: Daniel Müller <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #959 +/- ##
=======================================
Coverage 94.50% 94.50%
=======================================
Files 57 57
Lines 10603 10603
=======================================
Hits 10020 10020
Misses 583 583 ☔ View full report in Codecov by Sentry. |
|
Well, that wasn't particularly successful. For once I tried using the "auto-merge" feature and of course it just ignored failures and rushed ahead... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 12.13.x releases of symbolic-demangle result in broken Windows builds. Until that is fixed upstream, make sure that we use a lower version.